Errors still present in int_1xx_2xx_legacy.h

[Skarden]

Hello all,
I found some errors present into the file int_1xx_2xx_legacy.h in all the MPLAB 32 bits compilers versions.
Some have been corrected into the latest version of the compiler (the 1.20) but few are still present.

Basically the errors are the lines 34-35:

#ifndef _OLD_PIC32INT_5XX_6XX_7XX_HEADER_FILE
#define _OLD_PIC32INT_5XX_6XX_7XX_HEADER_FILE

that need to be changed in

#ifndef _OLD_PIC32INT_1XX_2XX_HEADER_FILE
#define _OLD_PIC32INT_1XX_2XX_HEADER_FILE



and the lines 694-697:

#define mCNSetIntPriority(priority)         (IPC6CLR = _IPC6_CNIP_MASK, IPC6SET = ((priority) << _IPC6_CNIP_POSITION))
#define mCNGetIntPriority()                 (IPC6bits.CNIP)
#define mCNSetIntSubPriority(subPriority)   (IPC6CLR = _IPC6_CNIS_MASK, IPC6SET = ((subPriority) << _IPC6_CNIS_POSITION))
#define mCNGetIntSubPriority()              (IPC6bits.CNIS)

that need to be changed in:

#define mCNSetIntPriority(priority)         (IPC8CLR = _IPC8_CNIP_MASK, IPC8SET = ((priority) << _IPC8_CNIP_POSITION))
#define mCNGetIntPriority()                 (IPC8bits.CNIP)
#define mCNSetIntSubPriority(subPriority)   (IPC8CLR = _IPC8_CNIS_MASK, IPC8SET = ((subPriority) << _IPC8_CNIS_POSITION))
#define mCNGetIntSubPriority()              (IPC8bits.CNIS)

I attached the corrected file; please replace the original present in the folder pic32mx\include\peripheral\legacy

Hoping this can help someone of you that "plays" with the 32MX150 or 32MX250 like me!
Regards

[cranor]

Hi,

UARTx defines are missing too.

For UART1, can't use ConfigIntUART1() without adding the following lines to the same file:


#ifdef _UART1
#define mU1EClearIntFlag()                  (IFS1CLR = _IFS1_U1EIF_MASK)
#define mU1EGetIntFlag()                    (IFS1bits.U1EIF)
#define mU1EGetIntEnable()                  (IEC1bits.U1EIE)
#define mU1EIntEnable(enable)               (IEC1CLR = _IEC1_U1EIE_MASK, IEC1SET = ((enable) << _IEC1_U1EIE_POSITION))
/*********************************************************************
 * UART 1 Receive
 ********************************************************************/
#define mU1RXClearIntFlag()                 (IFS1CLR = _IFS1_U1RXIF_MASK)
#define mU1RXGetIntFlag()                   (IFS1bits.U1RXIF)
#define mU1RXGetIntEnable()                 (IEC1bits.U1RXIE)
#define mU1RXIntEnable(enable)               (IEC1CLR = _IEC1_U1RXIE_MASK, IEC1SET = ((enable) << _IEC1_U1RXIE_POSITION))
/*********************************************************************
 * UART 1 Transfer
 ********************************************************************/
#define mU1TXClearIntFlag()                 (IFS1CLR = _IFS1_U1TXIF_MASK)
#define mU1TXGetIntFlag()                   (IFS1bits.U1TXIF)
#define mU1TXGetIntEnable()                 (IEC1bits.U1TXIE)
#define mU1TXIntEnable(enable)               (IEC1CLR = _IEC1_U1TXIE_MASK, IEC1SET = ((enable) << _IEC1_U1TXIE_POSITION))
/*********************************************************************
 * UART 1 Vector
 ********************************************************************/
#define mU1ClearAllIntFlags()               ( IFS1CLR = (_IFS1_U1EIF_MASK | _IFS1_U1RXIF_MASK | _IFS1_U1TXIF_MASK ))
#define mU1IntDisable()                     ( IEC1CLR = (_IEC1_U1EIE_MASK | _IEC1_U1RXIE_MASK | _IEC1_U1TXIE_MASK ))
#define mU1SetIntEnable(flags)             ( IEC1SET = ((flags)<<_IEC1_U1EIE_POSITION) )
#define mU1SetIntPriority(priority)         ( IPC8CLR = _IPC8_U1IP_MASK, IPC8SET = ((priority) << _IPC8_U1IP_POSITION))
#define mU1GetIntPriority()                 (IPC8bits.U1IP)
#define mU1SetIntSubPriority(subPriority)   ( IPC8CLR = _IPC8_U1IS_MASK, IPC8SET = ((subPriority) << _IPC8_U1IS_POSITION))
#define mU1GetIntSubPriority()              (IPC8bits.U1IS)
#endif

[Skarden]

Hello,
I included the definitions for the UART1 (cranor dixit), the UART2 and the SPI2.

Regards

[Gallymimu]

Please create a support ticket with microchip if you haven't.  They really like to get this feedback and use it to correct things.