Magazine project code - good or bad

[metal]

Real strange the way lcd.h was written. First time I see lcd.h containing many other defs and prototypes for things other than LCD :S

rclock.c, lcd.c and ds1307.c and with only two header files: lcd.h and i2cmaster.h... omg... what a real mess...

C true style is to keep routines of different parts of the project separate i.e. ds1307.c and ds1307.h, lcd.c and lcd.h, etc...

The funny thing is that DS1307_Read(char address) function prototype is found in lcd.h and the function body is found in ds1307.c and is depending heavily on lcd.c LCD routines, suppose I changed the lcd.h driver, what will happen? simply a disaster... Also there are many routine prototypes declarations in the same c file, which is something I strongly disagree with and like not to see.

All in all, nice project, but these authors seem unwilling to tidy their codes...

[microkid]

All of the projects has the same problem.  Most of the time we have to rewrite the code.

It is better to rework the project with your skills.

MicroKid

[pushycat]

Yes..i too agree with Metal and microkid. Despite Projects from EFY are innnovative, the codes are not upto expectations. No idea why the authors write such codes. Another vital point to be noted is, i personally never found the magazine code which works directly. Despite the codes are given on the magzine and the CD, the microcontroller based kits supplied by Kits n Spares (An Associate company of EFY) will have modified codes to make things work. I too personally rewrite or edit them to have a professisonal touch.
Pushy

[metal]

Elektor is suffering the same codes problem (Not working codes).

I think editors of such magazines don't really care if the codes are working or not, what really matters to them is the text and images of the article.